Skip to content
This repository was archived by the owner on Jan 21, 2023. It is now read-only.

Better error messages for unknown initialization keyword arguments #60

Merged
merged 4 commits into from
Nov 29, 2020

Conversation

Midnighter
Copy link
Owner

@Midnighter Midnighter commented Nov 27, 2020

I couldn't push to your branch (PR #51 addressing #50) so I've made a new branch. This pushes the keyword argument handling down to AbstractBase where multiple inheritance should never be an issue. Let me know what you think about this approach @yt-ms

@Midnighter Midnighter requested a review from yt-ms November 27, 2020 22:52
@Midnighter Midnighter self-assigned this Nov 27, 2020
@Midnighter Midnighter added the enhancement New feature or request label Nov 27, 2020
@codecov-io
Copy link

codecov-io commented Nov 27, 2020

Codecov Report

Merging #60 (0c5069d) into devel (ba22ca8) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel      #60      +/-   ##
==========================================
+ Coverage   90.11%   90.14%   +0.03%     
==========================================
  Files          68       68              
  Lines        1953     1959       +6     
  Branches      171      173       +2     
==========================================
+ Hits         1760     1766       +6     
  Misses        173      173              
  Partials       20       20              
Impacted Files Coverage Δ
src/structurizr/abstract_base.py 92.85% <100.00%> (+5.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba22ca8...0c5069d. Read the comment docs.

@Midnighter Midnighter changed the title Better error messages for unknown innitialization keyword arguments Better error messages for unknown initialization keyword arguments Nov 27, 2020
Copy link
Collaborator

@yt-ms yt-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One small suggestion to simplify.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make error message more intuitive if you get a wrong parameter on an element constructor
3 participants