Skip to content

fix proof-cache regeneration and move to script #17295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: compatible
Choose a base branch
from
Open

fix proof-cache regeneration and move to script #17295

wants to merge 3 commits into from

Conversation

Geometer1729
Copy link
Member

Explain your changes:

  • Fix a strange issue with nondeterminism in the proof cache regeneration
  • Move the script to regenerate it from src/lib/transaction_snark/README.md to scripts/regenerate-proof-cache.sh for ease of use.

Explain how you tested your changes:

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them

@Geometer1729
Copy link
Member Author

!ci-build-me

@Geometer1729
Copy link
Member Author

!ci-bypass-changelog

@Geometer1729
Copy link
Member Author

!ci-build-me

@georgeee
Copy link
Member

!ci-bypass-changelog

1 similar comment
@Geometer1729
Copy link
Member Author

!ci-bypass-changelog

@Geometer1729 Geometer1729 requested a review from georgeee May 30, 2025 18:14
@Geometer1729 Geometer1729 marked this pull request as ready for review May 30, 2025 19:28
@Geometer1729 Geometer1729 requested review from a team as code owners May 30, 2025 19:28
@Geometer1729
Copy link
Member Author

!ci-build-me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgeee georgeee Awaiting requested review from georgeee

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Geometer1729 @georgeee