feat: Add loading states and comprehensive modal accessibility #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Disable confirm button on submission with loading spinner - Add ARIA attributes for screen reader support - Implement keyboard navigation with focus trap - Add timeout handling (30 seconds) - Support dark mode for spinner - Add tests for button disable, spinner visibility, and ARIA attributes 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Change test implementation from async WebDriverWait pattern to atomic JavaScript execution to prevent stale element references. The new approach clicks the button and captures state (disabled, spinner visibility, aria-busy) in a single JS execution context, eliminating race conditions where DOM modifications invalidate element references. All 13 tests now pass reliably. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements loading states for modal actions and comprehensive accessibility improvements:
Loading States
aria-busy="true"on buttons during submissionAccessibility Improvements
role="dialog",aria-modal="true", andaria-labelledbyTests
test_button_disables_on_form_submission: Verifies button is disabled during processingtest_spinner_visible_during_submission: Confirms spinner appears when form is submittedtest_aria_busy_attribute_during_submission: Validates ARIA attributes are correctly setFiles Changed
modal_actions.js: Loading state management and accessibility implementation (156 lines changed)modal_actions.css: Spinner animation and loading styles (68 lines added)modal_actions.html: Button markup with spinner and ARIA live region (13 lines changed)test_modal_actions.py: Three new Selenium tests (93 lines added)Test plan
🤖 Generated with Claude Code