-
Notifications
You must be signed in to change notification settings - Fork 142
ring_attn_fp8_kv_fusion #787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+256
−16
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
ee69f31
ring_attn_fp8_kv_fusion
37febdb
main-sync
31fcd26
ring_attn_fp8_kv_fusion
5bf8f6d
ring_attn_fp8_kv_fusion_gemini_code_assist
19e3561
ring_attn_fp8_comm_kv_fusion
10e2701
Merge branch 'ModelTC:main' into xh/1
xiehaohx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| { | ||
| "infer_steps": 4, | ||
| "target_fps": 16, | ||
| "video_duration": 20, | ||
| "audio_sr": 16000, | ||
| "target_video_length": 81, | ||
| "resize_mode": "fixed_shape", | ||
| "fixed_shape": [ | ||
| 832, | ||
| 480 | ||
| ], | ||
| "self_attn_1_type": "sage_attn3", | ||
| "cross_attn_1_type": "sage_attn3", | ||
| "cross_attn_2_type": "sage_attn3", | ||
| "sample_guide_scale": 1, | ||
| "sample_shift": 5, | ||
| "enable_cfg": false, | ||
| "use_31_block": false, | ||
| "cpu_offload": false, | ||
| "offload_granularity": "block", | ||
| "offload_ratio": 1, | ||
| "t5_cpu_offload": true, | ||
| "t5_quantized": true, | ||
| "t5_quant_scheme": "fp8-sgl", | ||
| "clip_cpu_offload": true, | ||
| "clip_quantized": false, | ||
| "audio_encoder_cpu_offload": true, | ||
| "audio_adapter_cpu_offload": true, | ||
| "adapter_quantized": true, | ||
| "adapter_quant_scheme": "fp8-sgl", | ||
| "vae_cpu_offload": true, | ||
| "use_tiling_vae": false, | ||
| "dit_quantized": true, | ||
| "dit_quant_scheme": "fp8-sgl", | ||
| "parallel": { | ||
| "seq_p_size": 4, | ||
| "seq_p_attn_type": "ring", | ||
| "seq_p_fp8_comm": true, | ||
| "seq_p_head_parallel": true, | ||
| "seq_p_tensor_fusion": false | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The parameter
img_qkv_lenwas renamed toslice_qkv_lenin the method signature, which is a good change for generality. However, it's immediately reassigned to a local variableimg_qkv_len. For consistency and to improve code clarity, it would be better to useslice_qkv_lenthroughout the function's body, removing this redundant assignment.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To adapt to the project requirements, the input parameter must be named slice_qkv_len. In subsequent code, img_qkv_len used to differentiate between image and text components.