Handle null input in JsonOps.convertTo
#99
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
JsonOps.convertTothrows a null pointer exception wheninputisnullby callinginput.getAsJsonPrimitive()without checking fornull. Instead, the implementation only checks whetherinputis an implementation ofJsonNull. This is problematic because some of the other methods inJsonOpsreplace aJsonNullinstance withnullwhen returning it, which makes it possible thatinputisnullinstead of aJsonNullinstance. An example of such a method isJsonOps.getMapValues.This is an issue with the implementation of
convertToand not just a problem with call sites elsewhere, becauseconvertToalso usesgetMapValueswhen converting maps and it recursively callsconvertToon the returned map values, which means an input like{"value": null}is also going to throw an error even though it is a validJsonObjectinstance.This pull request adds a null check besides the
instanceofcheck forJsonNull, such that anullinput value and a value of typeJsonNullare handled the same inJsonOps.convertTo.This also fixes #62