Skip to content

Conversation

@legopitstop
Copy link
Contributor

  • Added more utilities to Vector2Utils
  • Added VectorXZUtils with the same methods as Vector2Utils.
  • Added tests for VectorXZUtils and new methods for Vector2Utils.
  • Core helper tests are now split up into 3 main groups (Vector3 operations, Vector2 operations, and Vectorxz operations) for organization.

Copy link
Collaborator

@rlandav rlandav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contributions! My only ask is that we want to make sure we have a parallel Vector2Builder method for each new method added (and a corresponding VectorXZBuilder now that you've added those functions too). Thanks!

@legopitstop
Copy link
Contributor Author

Added utilities to Vector2Builder and added VectorXZBuilder

Copy link
Collaborator

@rlandav rlandav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to the vector wrapper look good. Can you revert the lock file changes and the gameplay-utilities changes? You might have other changes locally that are getting merged in here. Once removed, I can merge this for you.

@legopitstop
Copy link
Contributor Author

Reverted package-lock.json and the gameplay-utilities.api.md changes.

@rlandav rlandav merged commit 696834c into Mojang:main Nov 1, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants