chore(deps): bump @molcrafts/molrs to 0.0.14 + io/overlay/runtime cleanup#20
Merged
Merged
Conversation
…anup
Bump @molcrafts/molrs ^0.0.12 → ^0.0.14 across the workspace and rebuild
package-lock.json. The only breaking change in molrs 0.0.13 is the
LAMMPSDumpReader rename to LAMMPSTrajReader; reader.ts and test_wasm.ts
adopt the new name. Beyond the bump, this batches in-flight refactors
that landed alongside the upgrade so master has a single coherent
state.
core
- io: replace normalize_coords with a column-based atom_coords helper
and a lazy frame reader, with new tests
- overlays: revamp mark_atom overlay flow + types/composite mark
- commands: refactor commands/index, frame, mark_atom, place_molecule
around the new entity_source / scene_index plumbing
- rpc: move buildFrame/buildBox tests from page/ to core/tests, where
the helpers actually live since b5dca14
- misc: trajectory, scene_index, modifiers (slice/wrap PBC),
pipeline/data_source_modifier touch-ups
vsc-ext
- split pathUtils into pure helpers (type-only vscode import) and a
new activeUri.ts that owns the runtime vscode.window dependency,
so unit tests can load pathUtils outside the extension host
- tighten tsconfig.test.json include glob to only the files unit
tests need (fixes rootDir / @molvis/core resolution)
- rename rslib config files .ts → .mts for proper ESM resolution
page
- drop the orphaned test_wasm_serialization (helpers moved to core);
pass --passWithNoTests so the empty test suite exits clean
python
- new molvis.runtime module + tests
- overlay/scene/catalog updates wired through to the new runtime
- drop the install_widget_stubs leftover from test_control/test_video
tooling
- biome: ignore .venv, .rslib, out, out-test (CI-clean checkout
matches local DX); fix package.json formatting
Verification
- npx biome check: 0 errors, 14 warnings (all configured warn)
- npm run typecheck: core + page + vsc-ext all green
- npm run test:core: 382/382
- npm run test:vsc-ext: 6/6
- npm run test:python: 98 passed, 2 skipped (PIL/ffmpeg optional)
- npm run build:all: core dist + page bundle + vsc-ext extension &
webview all green
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Bumps all workspaces (core, page, vsc-ext, root, python) from 0.0.4 to 0.0.5 and reconciles package-lock.json. Also narrows the page right sidebar's default width from 21% to 13% (with minSize 14% → 10% so the new default isn't clamped). v0.0.4 only partially shipped: PyPI and the VS Marketplace published, but the npm core release failed three times due to a package-lock.json drift that was fixed afterwards by MolCrafts#19. Re-tagging v0.0.4 cannot recover that because PyPI/Marketplace reject same-version republishes — 0.0.5 is the first version number where all three platforms can land aligned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@molcrafts/molrsfrom^0.0.12to^0.0.14. The only breakingchange in 0.0.13 is the
LAMMPSDumpReaderrename toLAMMPSTrajReader;this PR adopts the new name in
core/src/io/reader.tsandcore/tests/test_wasm.ts.lands in one coherent state instead of two interleaved series.
Changes by area
@molcrafts/molvis-coreio: replacenormalize_coordswith a column-basedatom_coordshelper plus a lazy frame reader (
lazy_reader.test.ts,data_source_modifier.test.ts).overlays: revamp themark_atomoverlay flow (composite mark + newtypes).
commands: refactorcommands/index,frame,mark_atom, andplace_moleculearound the updatedentity_source/scene_indexplumbing.
rpc: movebuildFrame/buildBoxtests frompage/tocore/tests/serialization.test.ts, where the helpers actually livesince b5dca14 (recovers coverage that was orphaned at that move).
vsc-extpathUtils.tsinto pure helpers (type-onlyvscodeimport) anda new
activeUri.tsthat owns the runtimevscode.windowdependency.This lets
pathUtilsunit tests load outside the extension host.tsconfig.test.jsonincludeglob so it only pulls in filesthe unit tests actually exercise — fixes the
rootDirviolationtriggered by
@molvis/core/io/formatsresolving tocore/src/io/.rslib.{extension,webview}.config.ts→.mtsfor proper ESMresolution.
pagetest_wasm_serialization.ts(the helpers moved tocore in b5dca14). Add
--passWithNoTestsso an empty page test suiteexits cleanly.
molvis(Python)molvis.runtimemodule + tests.scene/commands/overlay/commands/catalogupdates wiredthrough to the new runtime.
install_widget_stubsleftover fromtest_control/test_video(the modules they import no longer require it).Tooling
biome.json: ignore.venv,.rslib,out,out-testso a freshcheckout matches the CI environment.
package.jsonper Biome's expectation (workspaces arrayinline).
Test plan
npx biome check— 0 errors, 14 warnings (all configuredwarn)npm run typecheck— core + page + vsc-ext all greennpm run test:core— 382 / 382 passednpm run test:vsc-ext— 6 / 6 passed (mocha unit tests now loadthe split
pathUtilswithoutvscoderuntime)npm run test:python— 98 passed, 2 skipped (PIL / ffmpegoptional)
npm run build:all— core dist + page bundle (→python/src/molvis/dist/) + vsc-ext extension & webview allgreen;
molrs_bg.wasmbundled at the new 0.0.14 SHA.🤖 Generated with Claude Code