Skip to content

fix(core): add repository/homepage/bugs to package.json#21

Merged
Roy-Kid merged 1 commit into
MolCrafts:masterfrom
Roy-Kid:fix/core-repository-field
Apr 26, 2026
Merged

fix(core): add repository/homepage/bugs to package.json#21
Roy-Kid merged 1 commit into
MolCrafts:masterfrom
Roy-Kid:fix/core-repository-field

Conversation

@Roy-Kid
Copy link
Copy Markdown
Contributor

@Roy-Kid Roy-Kid commented Apr 26, 2026

Summary

  • Adds repository, homepage, and bugs fields to core/package.json so npm Trusted Publishing's sigstore provenance check can validate the upload.

Why

The v0.0.5 npm core release (run 24958572913) failed with:

```
422 Unprocessable Entity ... Error verifying sigstore provenance bundle:
package.json: "repository.url" is "", expected to match "https://github.com/MolCrafts/molvis"
```

Without the field, the comparison value was `""` and provenance validation rejected the upload. PyPI and VS Marketplace v0.0.5 published successfully — only npm core was blocked.

Plan after merge

`workflow_dispatch` on `release-core.yml`. The workflow uses the default branch ref, so it picks up this fix even though the v0.0.5 tag points to the old commit. Pure metadata fix; runtime is unchanged.

Test plan

  • Biome lint passes
  • Core tests pass (pre-commit hook)
  • After merge: re-run `release-core.yml` and confirm `@molcrafts/molvis-core@0.0.5` lands on npm

The v0.0.5 npm core publish failed with E422 because npm Trusted
Publishing's sigstore provenance check expects package.json's
repository.url to match the GitHub repo URL. Without the field, the
comparison value was "" and provenance validation rejected the upload.

Adds the standard repository/homepage/bugs trio so the next
workflow_dispatch run on release-core.yml lands cleanly. Pure metadata
fix — the published bundle's runtime is unchanged.
@Roy-Kid Roy-Kid merged commit c24855b into MolCrafts:master Apr 26, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant