feat: add getBalancesFetcher method to PrivacyChannel for UTXO balanc… #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e retrieval - Introduced a new method `getBalancesFetcher` in the `PrivacyChannel` class. - This method returns a function that fetches balances for given UTXO public keys. - Updated imports to include `UTXOPublicKey` and `Buffer` for handling UTXO data. - Enhanced readability by updating comments in the code.
… pre-configured transaction builders
…ount management - Implemented getUTXOAccountHandler in PrivacyChannel to create and return a UtxoBasedStellarAccount handler pre-configured for the privacy channel. - Added GetUTXOAccountHandlerArgs type to define the arguments required for the new method. - Updated types.ts to include Ed25519SecretKey in imports and defined the new GetUTXOAccountHandlerArgs type. - Modified index.ts in utxo-based-account to adjust the constructor to accept UTXOBasedAccountContructorArgs.
…r, and getUTXOAccountHandler methods in PrivacyChannel; change import to type for UTXOBasedAccountContructorArgs
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the PrivacyChannel class with convenience methods for working with UTXO-based accounts, refactors constructor arguments into a reusable type, and bumps the package version to 0.5.0.
Key Changes:
- Added three new public methods to
PrivacyChannel:getBalancesFetcher(),getTransactionBuilder(), andgetUTXOAccountHandler()to simplify UTXO account management - Extracted UTXO-based account constructor arguments into a reusable
UTXOBasedAccountContructorArgstype - Updated package version from 0.4.0 to 0.5.0
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| src/utxo-based-account/types.ts | Defines the new UTXOBasedAccountContructorArgs type to encapsulate constructor parameters |
| src/utxo-based-account/index.ts | Refactors constructor to use the new type definition |
| src/privacy-channel/types.ts | Adds GetUTXOAccountHandlerArgs type for the new UTXO account handler method |
| src/privacy-channel/index.ts | Implements three new convenience methods for balance fetching, transaction building, and UTXO account handling |
| deno.json | Bumps package version to 0.5.0 |
toruguera
approved these changes
Nov 13, 2025
Contributor
toruguera
left a comment
toruguera
left a comment
There was a problem hiding this comment.
Good structure improvement! 🚀
…XOAccountHandler method in PrivacyChannel
fazzatti
deleted the
feat/add-client-helping-functions-to-channel-client
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e retrieval
getBalancesFetcherin thePrivacyChannelclass.UTXOPublicKeyandBufferfor handling UTXO data.This pull request introduces several enhancements and refactorings to the privacy channel and UTXO-based account modules, focusing on extensibility and improved integration between components. The main changes include new helper methods in the
PrivacyChannelclass, type refactoring for better type safety and clarity, and improved constructor patterns for UTXO-based accounts.Privacy Channel Enhancements:
getBalancesFetcher,getTransactionBuilder, andgetUTXOAccountHandlerhelper methods to thePrivacyChannelclass, making it easier to fetch balances, create transaction builders, and instantiate UTXO-based account handlers pre-configured for the channel.Type and Constructor Refactoring:
UTXOBasedAccountContructorArgstype for a more structured and type-safe way to construct UTXO-based accounts, and updated theUtxoBasedAccountconstructor and related usages to use this new type. [1] [2]GetUTXOAccountHandlerArgstype to cleanly pass arguments (including options) when creating a UTXO account handler, omitting thefetchBalancesproperty to ensure it is injected by the privacy channel.Dependency and Version Updates:
0.4.0to0.5.0indeno.jsonto reflect these breaking and additive changes.Imports and Internal Consistency:
These changes collectively improve the modularity, type safety, and developer ergonomics of the privacy channel and UTXO-based account components.