fix: replace unsafe type assertions with proper types#31
Merged
Conversation
- Type TransactInput.op as xdr.ScVal instead of unknown - Fix Proxy set handler: correct trap signature (string | symbol), use direct property access for status, safe Record cast - Clarify Buffer type mismatch comment in provider signing
AquiGorka
force-pushed
the
fix/type-safety-improvements
branch
from
99f3721 to
d238d11
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
unknowntype forTransactInput.opwithxdr.ScValbased on contract spec andbuildXDR()return type@ts-ignorein Proxy set handler by using correct trap signature andRecordcastas anyin provider signing by convertingBuffertoUint8ArrayexplicitlyTest plan
deno checkpasses with no type errorsdeno task test:unit— no regressions