feat(web-components): add mrd-chip component - #137
Merged
Conversation
- Pill-shaped chip with color, variant (default/interactive/clearable) - Interactive variant adds role=button, tabindex, keyboard activation, and interaction layer - Clearable variant shows a remove button with its own interaction layer - Uses semantic color tokens (container/onContainer tonal pairing) - 8 unit tests including a11y checks via jest-axe - Storybook stories for all variants and colors Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
✅ Deploy Preview for mordech-react-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for mordech-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
… for chip component
Use ifDefined to avoid tabindex on non-interactive chips, add keyboard tests for interactive variant, use design token for label padding, and remove unused eslint-disable comment. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mrd-chipLit web component to@mordech/web-componentsvariantattribute:default(static label),interactive(clickable with interaction layer + keyboard support),clearable(remove button with its own interaction layer)colorattribute maps to semantic tonal token pair (container/onContainer) — supportsprimary,secondary,success,errorTest Plan
dist/components/mrd-chip.jsgenerated)