Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change desktop logger to Logback #501

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Avalancs
Copy link
Contributor

@Avalancs Avalancs commented Mar 12, 2020

Description

Work in progress, do not merge!
This is a prototype for #416. I got the Engine tests and desktop to work with SLF4J and Logback, but I do not know how to download the android part.

Testing

  1. Run JUnit tests from the Engine directory. They do not log anything, but you should not receive an exception from SLF4J about missing logger
  2. Start the game with the "run" task, and see if messages are printed to console

Outstanding Work

  • Download android, copy logback.xml to src/main/resource/assets/logback.xml
  • Replace ConsoleAppender with ch.qos.logback.classic.android.LogcatAppender inside the copied logback.xml
  • Change build.gradle to use
runtime group: 'com.github.tony19', name: 'logback-android', version: '2.0.0'
runtime group: 'com.github.tony19', name: 'logback-android-classic', version: '1.1.1-6'

instead of ch.qos.logback.

@GooeyHub
Copy link
Member

Hooray Jenkins reported success with all tests good!

@NicholasBatesNZ NicholasBatesNZ added the WIP Someone is still working on this label Mar 13, 2020
@NicholasBatesNZ NicholasBatesNZ added help wanted and removed WIP Someone is still working on this labels Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants