Add Windows-specific directory creation for gs_platform_dir_exists_default_impl#107
Open
reshen wants to merge 1 commit intoMrFrenik:masterfrom
Open
Add Windows-specific directory creation for gs_platform_dir_exists_default_impl#107reshen wants to merge 1 commit intoMrFrenik:masterfrom
gs_platform_dir_exists_default_impl#107reshen wants to merge 1 commit intoMrFrenik:masterfrom
Conversation
…_impl In msvc, turns out `mkdir` only takes a single argument so this code needs a minor tweak to handle that case. While I was looking at [the official docs](https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/mkdir?view=msvc-170), also noticed that `mkdir` is deprecated in favor of `_mkdir`, so made that change as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In msvc, turns out
mkdironly takes a single argument so this code needs a minor tweak to handle that case. While I was looking at the official docs, also noticed thatmkdiris deprecated in favor of_mkdir, so made that change as well.Without this patch:
With this patch:
p.s. Gunslinger is super cool, and your YT videos are fantastic. Appreciate you sharing your knowledge.