-
Notifications
You must be signed in to change notification settings - Fork 37
Add example fcl to run reco and trigger in one job #485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
michaelmackenzie
wants to merge
1
commit into
Mu2e:main
Choose a base branch
from
michaelmackenzie:RecoTrigger
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+71
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| # | ||
| # Reconstruct OnSpill events. This only reconstructs LoopHelices | ||
| # | ||
| #include "Production/JobConfig/reco/RecoTrig.fcl" | ||
| physics.RecoPath : [ @sequence::Reconstruction.OnSpillPath ] | ||
| physics.trigger_paths : [ @sequence::Trig_physMenu.trigger_paths, RecoPath ] | ||
|
|
||
| outputs: { | ||
| LoopHelixOutput : { | ||
| @table::Reconstruction.Output | ||
| SelectEvents : [ "RecoPath" ] | ||
| fileName: "rec.owner.description.version.sequencer.art" | ||
| } | ||
| } | ||
|
|
||
| # Disable LH filtering | ||
| physics.filters.LHFilter : { | ||
| module_type : FixedFilter | ||
| ReturnValue : true | ||
| } | ||
|
|
||
| physics.EndPath : [ LoopHelixOutput] | ||
| physics.end_paths : [ EndPath ] | ||
|
|
||
| #include "Production/JobConfig/reco/epilog.fcl" | ||
| #include "Production/JobConfig/common/epilog.fcl" | ||
| #include "mu2e-trig-config/core/trigDigiInputsEpilog.fcl" | ||
| #include "Production/JobConfig/reco/drop_trigger.fcl" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| # | ||
| # Drop the trigger results and re-run the trigger in addition to standard reco | ||
| # | ||
|
|
||
| # Reco includes | ||
| #include "Offline/fcl/minimalMessageService.fcl" | ||
| #include "Offline/fcl/standardServices.fcl" | ||
| #include "Production/JobConfig/reco/prolog.fcl" | ||
|
|
||
| # Trigger info, replacing the changes made in includes above | ||
| #include "mu2e-trig-config/core/trigProducers.fcl" | ||
| #include "mu2e-trig-config/core/trigFilters.fcl" | ||
| #include "mu2e-trig-config/core/trigRecoSequences.fcl" | ||
|
|
||
| BEGIN_PROLOG | ||
| # override the trigger digitization sequence (must be before trigSequences) | ||
| TrigRecoSequences.artFragmentsGen : [] | ||
| END_PROLOG | ||
|
|
||
| #include "mu2e-trig-config/core/trigSequences.fcl" | ||
|
|
||
| #include "mu2e-trig-config/gen/trig_physMenuPSConfig_OnSpill.fcl" | ||
| #include "mu2e-trig-config/gen/trig_physMenu_OnSpill.fcl" | ||
| # | ||
| process_name: Reconstruct | ||
| source : { module_type : RootInput } | ||
| services : @local::Services.Reco | ||
| physics : { | ||
| producers : { | ||
| @table::TrigProducers.producers | ||
| @table::Reconstruction.producers | ||
| } | ||
| filters : { | ||
| @table::TrigFilters.filters | ||
| @table::Trig_physMenuPSConfig | ||
| @table::Reconstruction.filters | ||
| } | ||
| analyzers: @local::Reconstruction.analyzers | ||
| @table::TrigSequences | ||
| trigger_paths : [ @sequence::Trig_physMenu.trigger_paths ] | ||
| } | ||
| # the following is a placeholder | ||
| #include "Production/Validation/database.fcl" | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There doen't seem to be any action associated with this comment: is it planned to add this functionality or is the comment out-of-date?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment was meant to give the intent of the fcl as a whole, rather than for a specific line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed the #include of drop_trigger.
When re-processing early MDC2020 data dropping the trigger was required to avoid problems with evolved schema, but AFAIK that's not true today. Are there other technical reasons why the drop needs to be embedded in this script? If not, it could be mixed in at the final .fcl stage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not positive if it's necessary, but the intent here was to produce a reco file with a single version of Online-configured reco instead of multiple versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this script be useful for comparing past/new triggers in a single job, event by event?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's possible, but I imagine you would need many input tag updates to not confuse the modules of which versions to select (e.g.
TrigMakeSH-->TrigMakeSH:Reco).