-
Notifications
You must be signed in to change notification settings - Fork 2
Parallel Optimization #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
It's weird that this didn't pull with the rest of the changes ...
Necessary due to acts-project/acts#3975
This only makes things build with v32 and v43, there are certainly versions in between where different changes would be necessary. (Potentially incomplete) list of related ACTS PRs: - acts-project/acts#3337 - acts-project/acts#4005
Fix Geo Mapping
Removed ROOT, EDM4hep, and Gaudi from the list of acts.
- Modified ACTSAlgBase to update geometry configuration - Added buildsub/, installsub/, and setup.sh to gitignore
…oothed track states
Fixing acts v43 runtime error from accessing non-smoothed track states
Comment for the constructor no longer applies (and maybe never has?). We cannot default construct a class that has a reference member.
copyFrom that takes a second boolean argument has been deprecated (technically only if the second argument == false). Corresponding acts PR: acts-project/acts#4570
Co-authored-by: Thomas Madlener <[email protected]>
Fix warnings and compilation issues for key4hep nightlies
|
The steering files for these new, parallel algs can be found here. |
|
Hi @samf25, we've merged the PR with the previous set of updates into the key4hep/main. We'll then merge this into our main, and start the PR to propagate the changes upstream. |
I made a number of changes to the algorithms in k4ActsTracking.
tbb's threading for the beefy for loop. This took the runtime (with BIB) from ~1000s to 0.5141s.