feat(dapp-kit): add CSS variables for connect button sizing and layout#857
Open
Dru1DD wants to merge 3 commits intoMystenLabs:mainfrom
Open
feat(dapp-kit): add CSS variables for connect button sizing and layout#857Dru1DD wants to merge 3 commits intoMystenLabs:mainfrom
Dru1DD wants to merge 3 commits intoMystenLabs:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
4 tasks
Contributor
|
Thanks for the contribution! I think #888 is probably more aligned with the direction we want to go. Exposing a few extra CSS variables is easy enough, but we'd ideally like to keep the theme set relatively contained and simple. I think styling the exposed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds additional CSS custom properties to mysten-dapp-kit-connect-button to allow consumers to customize button sizing and layout while preserving Shadow DOM encapsulation.
The change follows the existing --dapp-kit-* theming pattern and does not introduce any breaking changes or API modifications.
New CSS variables for the connect button:
These variables are defined with sensible defaults and can be overridden by consumers to better integrate the button into custom layouts and design systems.
Why?
Currently, consumers have limited control over the visual dimensions of the connect button (padding, height, radius), which makes integration into existing UI systems difficult.
This approach:
Example of usage
Backward compatibility
AI Assistance Notice