suins: add marketplace integration (auctions, offers, listings)#879
suins: add marketplace integration (auctions, offers, listings)#879gabrielmatei wants to merge 4 commits intoMystenLabs:mainfrom
Conversation
…nctionality, updating constants, codegen, and types.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
hayes-mysten
left a comment
There was a problem hiding this comment.
@gabrielmatei is there any additional context around these changes? I am not familiar with suins auctions, and don't see any docs in the PR that explains how/when this is intended to be used.
The patterns in the existing SDK are pretty old (we updated it to use codegen internally, but didn't want to update everything in the 2.0 release).
For new features it might make sense to more closely align with patterns from https://sdk.mystenlabs.com/sui/sdk-building
|
specifically, I would prefer to avoid adding more transaction building classes. so you can do soemthing like: tx.add(client.suins.call.createMarketplaceListing({
coinType: SUI_TYPE_ARG,
price: 1_000_000_000n,
suinsRegistration: nft,
}));instead of const marketplaceTx = new SuinsMarketplaceTransaction(client.suins, tx);
marketplaceTx.createListing({
coinType: SUI_TYPE_ARG,
price: 1_000_000_000n,
suinsRegistration: nft,
});Not attached specifically to certain names/locations for these methods, but justing using tx.add instead of creating a separate builder instances would probably be better, especially when its stateless |
Description
Adds marketplace support to the
@mysten/suinsSDK: auctions, fixed-price listings, and offers/counter-offers.auctionandofferMove modules via codegenSuinsMarketplaceTransactiontransaction builder methods using codegen bindingsTest plan
How did you test the new or updated feature?
tsc --noEmittestnetviatest/marketplace-live.test.ts.AI Assistance Notice