Skip to content

suins: add marketplace integration (auctions, offers, listings)#879

Open
gabrielmatei wants to merge 4 commits intoMystenLabs:mainfrom
buidly:suins/marketplace-integration
Open

suins: add marketplace integration (auctions, offers, listings)#879
gabrielmatei wants to merge 4 commits intoMystenLabs:mainfrom
buidly:suins/marketplace-integration

Conversation

@gabrielmatei
Copy link

Description

Adds marketplace support to the @mysten/suins SDK: auctions, fixed-price listings, and offers/counter-offers.

  • Generated TypeScript bindings for the auction and offer Move modules via codegen
  • Added SuinsMarketplaceTransaction transaction builder methods using codegen bindings
  • Added marketplace types and network config

Test plan

How did you test the new or updated feature?

  • TypeScript compilation and build verified via tsc --noEmit
  • Validated transaction flows on testnet via test/marketplace-live.test.ts.
  • All method signatures cross-referenced against generated bindings

AI Assistance Notice

Please disclose the usage of AI. This is primarily to help inform reviewers of how careful they need to review PRs, and to keep track of AI usage across our team. Please fill this out accurately, and do not modify the content or heading for this section!

  • This PR was primarily written by AI.
  • I used AI for docs / tests, but manually wrote the source code.
  • I used AI to understand the problem space / repository.
  • I did not use AI for this PR.

@vercel
Copy link

vercel bot commented Feb 18, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
sui-typescript-docs Ready Ready Preview, Comment Feb 18, 2026 10:11am

Request Review

@gabrielmatei gabrielmatei marked this pull request as ready for review February 24, 2026 12:17
@gabrielmatei gabrielmatei requested a review from a team as a code owner February 24, 2026 12:17
Copy link
Contributor

@hayes-mysten hayes-mysten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gabrielmatei is there any additional context around these changes? I am not familiar with suins auctions, and don't see any docs in the PR that explains how/when this is intended to be used.

The patterns in the existing SDK are pretty old (we updated it to use codegen internally, but didn't want to update everything in the 2.0 release).

For new features it might make sense to more closely align with patterns from https://sdk.mystenlabs.com/sui/sdk-building

@hayes-mysten
Copy link
Contributor

specifically, I would prefer to avoid adding more transaction building classes.

so you can do soemthing like:

tx.add(client.suins.call.createMarketplaceListing({
  coinType: SUI_TYPE_ARG,
  price: 1_000_000_000n,
  suinsRegistration: nft,
}));

instead of

const marketplaceTx = new SuinsMarketplaceTransaction(client.suins, tx);

marketplaceTx.createListing({
  coinType: SUI_TYPE_ARG,
  price: 1_000_000_000n,
  suinsRegistration: nft,
});

Not attached specifically to certain names/locations for these methods, but justing using tx.add instead of creating a separate builder instances would probably be better, especially when its stateless

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants