Simplification of leaf phenology parameters#1355
Conversation
…ngle, multi-option flag. This change simplifies the PFT set up and by default resolves possible incorrect settings of 3 mutually exclusive flags. Some of the associated code was also updated from if statements to select case, to ensure that options do not overlap.
…le phenology parameter.
glemieux
added
inputs: parameter file
glemieux
moved this from Todo
to Under Review
in FATES Pull Request Planning and Status
glemieux
left a comment
glemieux
left a comment
There was a problem hiding this comment.
Really nice work here. I made one comment suggesting a minor update to align with a code pattern update you made in one file, but it's not high priority.
biogeochem/EDPhysiologyMod.F90
Outdated
| ! but if the plant is seasonally (cold) deciduous, and the site status is flagged | ||
| ! as "cold", then set the cohort's status to leaves_off, and remember the leaf biomass | ||
| if ((prt_params%season_decid(ft) == itrue) .and. & | ||
| if ((prt_params%phen_leaf_habit(ft) == ihard_season_decid) .and. & |
There was a problem hiding this comment.
It looks like we could move this into the select case statement down on line 2571 correct? This would mirror the work you made earlier in this file.
There was a problem hiding this comment.
Thanks for the suggestion! I moved this part to the select case block below.
github-project-automation
bot
moved this from Under Review
to Final Testing
in FATES Pull Request Planning and Status
two-stream sun-shade fraction update This simplifies the leaf sunlit fraction calculation to assume that it is comparible to that of other media.
|
Regression testing underway on |
|
Regression testing against I've created a temporary baseline for this on I'd like to integrate this via a super PR that also integrates #1358 and #1359 in coordination with ESCOMP/CTSM#3087, so we're going to hold on integration. Results: UPDATE: this has been merged into #1406. It will be automatically merged when that #1406 is integrated. |
glemieux
moved this from Final Testing
to Hold
in FATES Pull Request Planning and Status
github-project-automation
bot
moved this from Hold
to Ready to Integrate
in FATES Pull Request Planning and Status
updates to the default parameter file This update includes a phenology parameter refactor per NGEET#1355, an update to the default exclusion parameter per NGEET#1358, updates to the logging parameters to default to clearcut via NGEET#1359, and a minor long name correction per NGEET#1394.
updates to the default parameter file This update includes a phenology parameter refactor per NGEET#1355, an update to the default exclusion parameter per NGEET#1358, updates to the logging parameters to default to clearcut via NGEET#1359, and a minor long name correction per NGEET#1394.
2 participants
Description:
The goal of this pull request is to simplify how we define leaf phenological habit for PFTs. We currently need to define three parameters (
fates_phen_evergreen,fates_phen_season_decid,fates_phen_stress_decid), which must be mutually exclusive (i.e., only one of them can be non-zero for any PFT). This pull request replaces these parameters with a single one (fates_phen_leaf_habit) which allows selecting which phenological habit to use:This change will simplify creating new phenological habits in the future, as everything would be still handled by one parameter. It also avoids early crashes at the beginning of the model run, because this approach ensures the different habits are mutually exclusive.
Collaborators:
Expectation of Answer Changes:
These changes are intended to be bit-for-bit, the only change is in how we store information regarding leaf phenology.
Checklist
If this is your first time contributing, please read the CONTRIBUTING document.
All checklist items must be checked to enable merging this pull request:
Contributor
Integrator
Documentation
Test Results:
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: