Complete the FATES-CLM nitrogen coupling#1472
Open
slevis-lmwg wants to merge 17 commits intoNGEET:mainfrom
Open
Complete the FATES-CLM nitrogen coupling#1472slevis-lmwg wants to merge 17 commits intoNGEET:mainfrom
slevis-lmwg wants to merge 17 commits intoNGEET:mainfrom
Conversation
This renaming of variables corresponds to 116b310cd20f29bf5ca07b1d89f9e812f4e94477
slevis-lmwg
commented
Oct 9, 2025
slevis-lmwg
commented
Dec 8, 2025
Contributor
Author
|
From meeting with @rgknox |
1 task
Contributor
Author
|
Ryan's update 2025/12/15: In our meeting 2025/12/16 Ryan offered to change the integer values (1 and 2) to strings. (I made the change from hardwired values to named params in the code.) |
This changes how we regulate root proportions, such that in CNP mode root proportions are not allowed to change while both N and P are supplementing. This was introduced by Bharat Sharma. slevis resolved conflicts: biogeochem/EDPhysiologyMod.F90 main/EDMainMod.F90 main/EDPftvarcon.F90 main/FatesInterfaceMod.F90
JSON formatted parameter files.
namespace changes (WIP)
slevis-lmwg
commented
Feb 7, 2026
Co-authored-by: Samuel Levis <slevis@ucar.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
I started this PR with changes needed in ESCOMP/CTSM#3409.
So far that's just the renaming of
prt_carbon_allom_hyp to fates_c_only
prt_cnp_flex_allom_hyp to fates_cn
The corresponding ESCOMP issue:
ESCOMP/CTSM#3378
Resolves #1454
Reminder to address #1526
Collaborators:
@rgknox
@adrifoster
Expectation of Answer Changes:
I do not expect answers to change as a result of this PR alone; however, I expect answers to change for
fates_parteh_mode = 2as a result of the corresponding ESCOMP PR. So far I have not seen such diffs, while I have seen diffs forfates_parteh_mode = 1.Checklist
All checklist items must be checked to enable merging this pull request:
Contributor
Integrator
If satellite phenology regressions are not b4b, please hold merge and notify the FATES development team.
Documentation
Test Results:
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: