Update hydraulic failure mortality for places with frozen soils#1533
Update hydraulic failure mortality for places with frozen soils#1533JessicaNeedham wants to merge 11 commits intoNGEET:mainfrom
Conversation
|
I'm wondering if there should be a new function that gets the maximum soil layer index with 90% of root biomass so that we don't have to duplicate that chunk of code before each call to mortality_rates? |
|
We could also simplify things a lot by evaluating only the active layers. i.e. calculate hmort if
|
mpaiao
left a comment
There was a problem hiding this comment.
@JessicaNeedham thanks for submitting this PR! I think your implementation makes total sense and is simple and elegant. It is also consistent with how btran is calculated.
|
Thanks @mpaiao ! I am also testing a version now where only 50% of the active layer need to be thawed before we allow hydraulic failure. Discussing with @rosiealice we thought maybe the whole active layer having to be thawed was a bit restrictive. |
| else | ||
| ! When FATES-Hydro is off, hydraulic failure mortality occurs only when btran | ||
| ! falls below a threshold and plants have leaves. | ||
| n_layer_thawed = count((bc_in%t_soisno_sl - tfrz ) > soil_tfrz_thresh) |
There was a problem hiding this comment.
@JessicaNeedham , could we also perform this logic based off of the fraction of non-frozen depth, or the fraction of non-frozen fine-root biomass? That might buffer this calculation from artificial model constructs like how we decide on layering.
There was a problem hiding this comment.
@rgknox yes it also occurred to me we could get quite different behaviour here if the HLM layering scheme changed. I might have missed something, but it looked to me like FATES doesn't actually see the thickness of each HLM soil layer, which makes it hard to do this by depth, rather than number of soil layers. Making it by root biomass works, and that was what I originally wrote. It is a bit clunkier but maybe safer (see this first commit).
| if ( (.not. is_decid_dormant) .and. & | ||
| ( btran_ft(cohort_in%pft) <= hf_sm_threshold ) .and. & | ||
| ( ( minval(bc_in%t_soisno_sl) - tfrz ) > soil_tfrz_thresh ) ) then | ||
| ( n_layer_thawed .ge. (0.5_r8 * nlev_eff_soil) )) then |
There was a problem hiding this comment.
Recommend setting 0.5 to a named constant like "hmort_thaw_frac_threshold" or whatever you deem appropriate
|
@rgknox - this is back to being based on root biomass. Tests running with NorESM. |
|
I ran two simulations where soil layers with either 25% or 75% of root biomass thawed before hydraulic failure mortality is allowed. All PFTs had hydraulic failure mortality set to 0.25. There is very little difference except for at the highest latitudes. |













This PR address issue #1492.
Hydraulic failure mortality (hmort) occurs when btran is less than a soil moisture threshold. If soils are frozen then btran is zero. To prevent hmort of plants at high latitude during winter there is an if statement that prevents hmort being calculated if any soil layer is frozen. However, in regions with permafrost this essentially turns off hmort entirely, even in summer months when plants may actually be water stressed.
This PR adds additional logic so that we still calculate hmort if soil layers with 90% of the root biomass are not frozen.
Collaborators:
@mvdebolskiy @rosiealice @kjetil
Expectation of Answer Changes:
This will change hmort rates of plants at high latitudes.
Checklist
If this is your first time contributing, please read the CONTRIBUTING document.
All checklist items must be checked to enable merging this pull request:
Contributor
Integrator
If satellite phenology regressions are not b4b, please hold merge and notify the FATES development team.
Documentation
Test Results:
Not tested