Fix infra-keep-probing for low infra-cache-max-rtt values #1241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(configurable) infra-cache-max-rtt value. That could result in infra-keep-probing not working if an infra-cache-max-rtt value was chosen that was below 12000 ms. This fix still uses a default value of 12000 ms for the probe but caps it to the infra-cache-max-rtt if that is lower.
wcawijngaards
approved these changes
Feb 19, 2025
gthess
added a commit
that referenced
this pull request
Feb 19, 2025
- Merge #1241: Fix infra-keep-probing for low infra-cache-max-rtt values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The maximum value of a probe rto was not aligned with the (configurable)
infra-cache-max-rttvalue. That could result ininfra-keep-probingnot working if aninfra-cache-max-rttvalue was chosen that was below 12000 ms.This fix still uses a default value of 12000 ms for the probe but caps it to the
infra-cache-max-rttif that is lower.