Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#23 Start to add schema for static sources in pp yamls #24

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

singhd789
Copy link
Contributor

No description provided.

@singhd789 singhd789 marked this pull request as ready for review March 7, 2025 13:54
Copy link
Contributor

@ceblanton ceblanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty good! I think we would like variables to be within the history file or offline history file, if possible, and I wasn't sure if history_file was offline or from the model output.

Dana Singh added 2 commits March 7, 2025 10:19
- remove freq
- (have to assess what to do with variables)
@singhd789 singhd789 requested a review from ceblanton March 7, 2025 15:29
@singhd789
Copy link
Contributor Author

Thanks @J-Lentz for the catches!

@singhd789 singhd789 requested a review from J-Lentz March 7, 2025 19:52
Copy link
Contributor

@ceblanton ceblanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I still think the variables has to be a element (?? not sure the yaml hame) within sources or offline_sources instead of a peer of sources and offline_sources. Let's discuss...

FRE/fre_pp.json Outdated
}
},
"offline_sources": {
"description": "Path to history file if static source is for offline diagnostics",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A tiny nit.. "history file" implies model output. Not sure what to call it though!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

offline diagnostic?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that works!

@singhd789
Copy link
Contributor Author

Looking good! I still think the variables has to be a element (?? not sure the yaml hame) within sources or offline_sources instead of a peer of sources and offline_sources. Let's discuss...

I agree with this schema of

  components:
    - type: 'ocean'
      sources: ["ocean_month", "ocean_daily"]
      static:
        - sources: ["ocean_static"]
          variables: ["hgfeou"]
        - sources: ["ocean_bgc_static"]
        - offline_sources: ["/home/c2b/cmip6/offline/ocean_grids.nc"]
          variables: ["deptho", "sftof"]
        - offline_sources: ["/home/c2b/cmip6/offline/basins.nc"]

I believe the schema reflects that now as well (at least it appeared valid in my slight tests). @J-Lentz - do you know if the schema currently reflects this kind of yaml format?

@singhd789 singhd789 requested review from J-Lentz and ceblanton March 12, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants