EpicsMotorIOC

[malitsky]

No description provided.

[codecov-io]

Codecov Report

Merging #62 into master will increase coverage by 3.28%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
+ Coverage   52.16%   55.45%   +3.28%     
==========================================
  Files          11       12       +1     
  Lines         692      743      +51     
==========================================
+ Hits          361      412      +51     
  Misses        331      331

Impacted Files	Coverage Δ
nslsii/tests/test_epstwostate_ioc.py	100% <ø> (ø)
nslsii/tests/test_epicsmotor_ioc.py	100% <100%> (ø)
nslsii/tests/temperature_controllers_test.py	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd076a7...b35b936. Read the comment docs.

[awalter-bnl]

I would like to resolve the confusion and issues with the tests prior to merging see above comment chain.

[awalter-bnl]

@klauer thanks for the review request, however I already have reviewed this a few times. The last concerns I had related to the location of the test files which @malitsky resolved, hence why I approved it.

Clearly their are still some outstanding comments from @tacaswell that require resolution.

[tacaswell]

The test should be split up into multiple tests and the clean up logic moved to a fixture.

The time.sleep needs be removed.

The questions about how this behaves to semi-pathological input should be answered, but we can discuss if fixing that is in scope for this or not.

Removing approval pending resolution of @tacswell ‘s comments

[malitsky]

PR updated with Tom's comments.

[malitsky]

fyi, @tacaswell and @awalter-bnl