draft: adding de-tuning to mono object#30
Open
Jennefer Maldonado (jennmald) wants to merge 11 commits into
Open
draft: adding de-tuning to mono object#30Jennefer Maldonado (jennmald) wants to merge 11 commits into
Jennefer Maldonado (jennmald) wants to merge 11 commits into
Conversation
Jennefer Maldonado (jennmald)
requested a review
from Thomas A Caswell (tacaswell)
Contributor
Author
|
need to test before merging, but is this looking better? |
gjwillms
reviewed
May 18, 2026
gjwillms
reviewed
May 18, 2026
gjwillms
reviewed
May 18, 2026
gjwillms
reviewed
May 18, 2026
| if not self.move_u_gap.get(): | ||
| u_gap = self.u_gap.position | ||
|
|
||
| return self.RealPosition(bragg=np.rad2deg(bragg), c2_x=c2_x, cgap=u_gap) |
gjwillms
reviewed
May 18, 2026
gjwillms
reviewed
May 18, 2026
gjwillms
reviewed
May 18, 2026
gjwillms
reviewed
May 18, 2026
gjwillms
reviewed
May 18, 2026
gjwillms
reviewed
May 18, 2026
gjwillms
reviewed
May 18, 2026
gjwillms
reviewed
May 18, 2026
gjwillms
left a comment
gjwillms
left a comment
There was a problem hiding this comment.
Please consider the following. Especially note the rework around the type of peak-up scan to be performed. This is already confusing in the SRX code where the two types--measure total and differential signal on a BPM from either a Ti or Cu foil when the target energy is far from their respective edges in a fixed, in-vacuum device or scanning a reference sample at the sample location--are already confusing. I suggest that if no element is provided, the remainder of the set-up of the xpress3 fluorescence analysis is not performed. CDI doesn't have one anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.