Normalize linker path inputs to prevent absolute-path overrides#18
Draft
Copilot wants to merge 2 commits into
Draft
Normalize linker path inputs to prevent absolute-path overrides#18Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Agent-Logs-Url: https://github.com/NSLS2/cms-workflows/sessions/5377da0e-fd91-44b7-aaf0-39636cc60e17 Co-authored-by: swu4bnl <205365658+swu4bnl@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Make experiments directory handling more robust in linker.py
Normalize linker path inputs to prevent absolute-path overrides
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
linker.pypreviously hard-codedexperimentsand directly joined user-supplied directory values, which allowed values like/experimentsor/to behave ambiguously or override the intended base path semantics. This change normalizes user path inputs to relative segments before joining under the proposal directory.Path normalization in linker flow
Pathsegment."experiments"usage with normalizeddoc.get("experiments_directory", "experiments").experiment_alias_directorybefore join.Behavioral intent
"experiments","/experiments", and"/"are treated as relative-to-proposal path components.Focused regression coverage