Skip to content

Scrolling When Modals are Open #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Scrolling When Modals are Open #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 23 additions & 9 deletions components/elements/learn/capsule-unit.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
color:#242424;
border-radius:4px;
width:100%;

-webkit-transition: all 150ms ease-in-out;
-moz-transition: all 150ms ease-in-out;
-o-transition: all 150ms ease-in-out;
Expand Down Expand Up @@ -100,8 +101,7 @@
#capsule-content {
display:none;
height:100%;
/*overflow-y:scroll;*/
overflow:hidden;
overflow-y: scroll;
padding:40px;

-webkit-transition: opacity 500ms ease-in-out;
Expand Down Expand Up @@ -147,7 +147,8 @@
width:100%;
height:100%;
visibility: hidden;
overflow:hidden;
overflow: hidden;

-webkit-transition: all 750ms cubic-bezier(0.770, 0.000, 0.175, 1.000);
-moz-transition: all 750ms cubic-bezier(0.770, 0.000, 0.175, 1.000);
-o-transition: all 750ms cubic-bezier(0.770, 0.000, 0.175, 1.000);
Expand Down Expand Up @@ -295,6 +296,8 @@ <h2 id="capsule-content-header">{{ header }}</h2>

attached: function() {
var self = this;
this.parent_page_item = this._findPageItem(this);

this.capsule_image.style.backgroundImage = "url(" + this.image + ")";

this.capsule_ref.addEventListener("click", function(e) {
Expand Down Expand Up @@ -398,14 +401,17 @@ <h2 id="capsule-content-header">{{ header }}</h2>

},

_findPageItem: function(e) {
if (e.tagName == "PAGE-ITEM") return e;
if (e.parentElement == null) return e;
return this._findPageItem(e.parentElement);
},

windowOn:function(e) {
function findPageItemRect(e) {
if (e.tagName == 'PAGE-ITEM') return e.getContainerRect();
if (e.parentElement == null) return e.getBoundingClientRect();
return findPageItemRect(e.parentElement);
}

var page_item_rect = findPageItemRect(this);
var page_item = this.parent_page_item.$['page-item']
var page_item_rect = this.parent_page_item.getContainerRect();

var container_top = this.capsule_content_container.getBoundingClientRect();

var modal_width = 0,
Expand Down Expand Up @@ -448,12 +454,20 @@ <h2 id="capsule-content-header">{{ header }}</h2>
this.capsule_page_block.style.visibility = "visible";
// this.container.style.top = -container_top + "px";
// this.container.setAttribute("elevation", "5");

// PREVENT SCROLLING OUTSIDE OF MODAL
page_item.style.overflow = 'hidden';

},

windowOff: function(e) {
this.window_open = true;
var self = this;

// REENABLE SCROLLING
this.parent_page_item.$['page-item'].style.overflow = 'auto';


this.capsule_page_block.style.visibility = "hidden";

this.capsule_content_container.style.left = "0px";
Expand Down
Loading