-
Notifications
You must be signed in to change notification settings - Fork 10
feat(pydantic-validation): pydantic config validation #454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
… not permitted Signed-off-by: Anna Warno <[email protected]>
|
When we have e.g. typo: |
|
/ok to test d85da06 |
Signed-off-by: Anna Warno <[email protected]>
…m/NVIDIA-NeMo/Evaluator into awarno/pydantic-config-validation
|
/ok to test 2eed38c |
Signed-off-by: Anna Warno <[email protected]>
|
/ok to test ea15b2f |
agronskiy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sounds legit to me!
| # Merge legacy config with defaults to avoid repeated .get() calls | ||
| defaults = cls.get_legacy_defaults() | ||
| legacy_config = {**defaults, **legacy_config} | ||
| from pydantic import ValidationError |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: feels like this belongs to the top level import up there (you already have from pytdantic). And same for logging.
Signed-off-by: Anna Warno <[email protected]>
|
/ok to test 4de6d2d |
pydantic config validation with extra field not permitted