fix: handle llama.cpp context overflow in model adapter - #3371
Open
wefstratis-nv wants to merge 1 commit into
Open
wefstratis-nv wants to merge 1 commit into
wefstratis-nv wants to merge 1 commit into
Conversation
Signed-off-by: wefstratis <wefstratis@nvidia.com>
ananthsub
reviewed
Sep 14, 2026
ananthsub
left a comment
Contributor
There was a problem hiding this comment.
thanks @wefstratis-nv for the contribution! could you address the merge conflicts with the latest main so we can merge?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Handle llama.cpp context-overflow errors in the OpenAI-compatible model adapter.
Previously, llama.cpp HTTP 400 errors such as
exceed_context_size_errorwere not recognized and caused evaluation failures. These errors now follow the existing context-length handling: return an empty completion withfinish_reason="length".The change covers both chat-completions and completions paths. Unrelated errors continue to propagate.
Validation:
--all-filescommand has not been run.Checklist
pre-commit run --all-files) (so CI lint/format/copyright pass).git commit -s) (so the DCO check passes).