Skip to content

Deletes the global git config file in rosetta images to avoid silently committing as the [email protected] user #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Deletes the global git config file in rosetta images to avoid silently committing as the [email protected] user #370

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions rosetta/Dockerfile.pax
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,13 @@ ENV ENABLE_TE=1

ARG GIT_USER_EMAIL
ARG GIT_USER_NAME
RUN <<EOF bash -e
git config --global user.email "${GIT_USER_EMAIL}"
git config --global user.name "${GIT_USER_NAME}"
EOF

COPY --from=rosetta-source / /opt/rosetta
WORKDIR /opt/rosetta
RUN --mount=target=/opt/pax-mirror,from=pax-mirror-source,readwrite \
--mount=target=/opt/praxis-mirror,from=praxis-mirror-source,readwrite <<"EOF" bash -e
git config --global user.email "${GIT_USER_EMAIL}"
git config --global user.name "${GIT_USER_NAME}"
bash create-distribution.sh \
-p patchlist-paxml.txt \
-m https://github.com/nvjax-svc-0/paxml.git \
Expand All @@ -36,6 +34,6 @@ bash create-distribution.sh \
-m https://github.com/nvjax-svc-0/praxis.git \
-d $(dirname $(python -c "import praxis; print(*praxis.__path__)")) \
-e /opt/praxis-mirror
rm -rf $(find /opt -name "__pycache__")
rm -rf $(find /opt -name "__pycache__") ~/.gitconfig
EOF

8 changes: 3 additions & 5 deletions rosetta/Dockerfile.t5x
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,13 @@ ENV ENABLE_TE=1

ARG GIT_USER_EMAIL
ARG GIT_USER_NAME
RUN <<EOF bash -e
git config --global user.email "${GIT_USER_EMAIL}"
git config --global user.name "${GIT_USER_NAME}"
EOF

COPY --from=rosetta-source / /opt/rosetta
WORKDIR /opt/rosetta
RUN --mount=target=/opt/t5x-mirror,from=t5x-mirror-source,readwrite \
--mount=target=/opt/flax-mirror,from=flax-mirror-source,readwrite <<"EOF" bash -e
git config --global user.email "${GIT_USER_EMAIL}"
git config --global user.name "${GIT_USER_NAME}"
bash create-distribution.sh \
-p patchlist-t5x.txt \
-m https://github.com/nvjax-svc-0/t5x.git \
Expand All @@ -36,7 +34,7 @@ bash create-distribution.sh \
-m https://github.com/nvjax-svc-0/flax.git \
-d $(dirname $(python -c "import flax; print(*flax.__path__)")) \
-e /opt/flax-mirror
rm -rf $(find /opt -name "__pycache__")
rm -rf $(find /opt -name "__pycache__") ~/.gitconfig
EOF

WORKDIR /opt/rosetta
Expand Down