-
Notifications
You must be signed in to change notification settings - Fork 108
Make sure we pass device="meta" to TE layers during meta device init #1397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trvachov
reviewed
Dec 29, 2025
8ca75dc to
919f984
Compare
cspades
approved these changes
Jan 5, 2026
Signed-off-by: Peter St. John <[email protected]>
Signed-off-by: Peter St. John <[email protected]>
Signed-off-by: Peter St. John <[email protected]>
Signed-off-by: Peter St. John <[email protected]>
Signed-off-by: Peter St. John <[email protected]>
…asses to use a consistent initialization function. Update tests to ensure weight initialization matches expected values with adjusted tolerances for standard deviation. Signed-off-by: Peter St. John <[email protected]>
Signed-off-by: Peter St. John <[email protected]>
Signed-off-by: Peter St. John <[email protected]>
Signed-off-by: Peter St. John <[email protected]>
Signed-off-by: Peter St. John <[email protected]>
Signed-off-by: Peter St. John <[email protected]>
Signed-off-by: Peter St. John <[email protected]>
Signed-off-by: Peter St. John <[email protected]>
Signed-off-by: Peter St. John <[email protected]>
Signed-off-by: Peter St. John <[email protected]>
Signed-off-by: Peter St. John <[email protected]>
adc9525 to
48f573d
Compare
Signed-off-by: Peter St. John <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TransformerEngine requires that we pass
device="meta"(and importantly notdevice=torch.device("meta")) to layer constructors to initialize parameters on the meta device.This makes sure we pass the right device to the layer constructor and adds tests to ensure the parameters are actually being placed on the right devices.
For TransformerEngine layers, we want to be moving parameters from the meta device to cuda with
while for HF layers (e.g., nn.Embedding), we want to be doing
to ensure that we pick up the config.initializer_range initialization correctly.
The issue is that we can't do
to_empty("cuda")or_init_weightson TE layers, nor can we doreset_parameters()on the HF layers without the preceedingto_empty, and this doesn't use the HF config when creating initial values.Closes BIO-1