-
Notifications
You must be signed in to change notification settings - Fork 108
Deprecate 5D geneformer. #1398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate 5D geneformer. #1398
Conversation
Signed-off-by: Timur Rvachov <[email protected]>
e136a81 to
bf83d4e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1398 +/- ##
==========================================
- Coverage 79.02% 76.53% -2.50%
==========================================
Files 121 101 -20
Lines 9079 7932 -1147
==========================================
- Hits 7175 6071 -1104
+ Misses 1904 1861 -43 |
097fefa to
70bb80a
Compare
pstjohn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but maybe clarify that we're no longer supporting "5D" parallelism for these models
|
Can you also remove from ci/benchmarks geneformer scripts, so we no longer run the JET tests: |
Signed-off-by: Timur Rvachov <[email protected]>
Signed-off-by: Timur Rvachov <[email protected]>
70bb80a to
b624522
Compare
|
@jwilber removed ci scripts -- thanks! |
|
/ok to test 809acda |
Description
Removes Geneformer model from sub-packages and updates documentation. Future iterations of Geneformer will be in bionemo-recipes
Usage
Type of changes
CI Pipeline Configuration
Configure CI behavior by applying the relevant labels. By default, only basic unit tests are run.
Unit tests marked as
@pytest.mark.multi_gpuor@pytest.mark.distributedare not run in the PR pipeline.For more details, see CONTRIBUTING
Note
By default, only basic unit tests are run. Add appropriate labels to enable an additional test coverage.
Authorizing CI Runs
We use copy-pr-bot to manage authorization of CI
runs on NVIDIA's compute resources.
automatically be copied to a pull-request/ prefixed branch in the source repository (e.g. pull-request/123)
/ok to testcomment on the pull request to trigger CI. This will need to be done for each new commit.Pre-submit Checklist