[CUB] Fix mask types in block_radix_rank.cuh #6189
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
miscco
requested changes
Oct 13, 2025
Contributor
miscco
left a comment
miscco
left a comment
There was a problem hiding this comment.
Thanks a lot, We can now drop some of the internal casts
Contributor
|
/ok to test 4887eb0 |
This comment has been minimized.
This comment has been minimized.
Contributor
|
We should probably review the generated SASS once this PR is ready. |
miscco
approved these changes
Oct 13, 2025
Contributor
|
/ok to test fb741b1 |
Contributor
🥳 CI Workflow Results🟩 Finished in 3h 24m: Pass: 100%/75 | Total: 2d 18h | Max: 3h 22m | Hits: 85%/73707See results here. |
fbusato
reviewed
Oct 13, 2025
Aminsed
force-pushed
the
bugfix/mask_uint32_types
branch
from
fefe4a3 to
ec8926d
Compare
Aminsed
force-pushed
the
bugfix/mask_uint32_types
branch
from
0071054 to
9c228a8
Compare
miscco
requested changes
Oct 27, 2025
Comment on lines
+722
to
+730
| using ::cuda::std::uint32_t; | ||
| uint32_t warp_id = linear_tid >> LOG_WARP_THREADS; | ||
| uint32_t lane_mask_lt = ::cuda::ptx::get_sreg_lanemask_lt(); | ||
|
|
||
| _CCCL_PRAGMA_UNROLL_FULL() | ||
| for (int ITEM = 0; ITEM < KEYS_PER_THREAD; ++ITEM) | ||
| { | ||
| // My digit | ||
| ::cuda::std::uint32_t digit = digit_extractor.Digit(keys[ITEM]); | ||
| uint32_t digit = digit_extractor.Digit(keys[ITEM]); |
Contributor
There was a problem hiding this comment.
There is only one occurrence, please use the fully qualified one there
| ::cuda::std::uint32_t bin_mask = *p_match_mask; | ||
| int leader = ::cuda::std::__bit_log2(bin_mask); | ||
| int warp_offset = 0; | ||
| int popc = __popc(bin_mask & ::cuda::ptx::get_sreg_lanemask_le()); |
Contributor
There was a problem hiding this comment.
We need to use ::cuda::std::popcount
fbusato
requested changes
Oct 27, 2025
| int lane_mask = 1 << lane; | ||
| int* warp_offsets = &s.warp_offsets[warp][0]; | ||
| int* match_masks = &s.match_masks[warp][0]; | ||
| ::cuda::std::uint32_t lane_mask = 1 << lane; |
Contributor
There was a problem hiding this comment.
A better alternative is
Suggested change
| ::cuda::std::uint32_t lane_mask = 1 << lane; | |
| auto lane_mask = 1u << lane; |
signed shift is UB before C++20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
uint32_tfor bitmasks in block_radix_rank.cuh.cuda::stdfunctionsFixes #6106