Skip to content

Conversation

Aminsed
Copy link

@Aminsed Aminsed commented Oct 13, 2025

Fix BlockRadixRank documentation issues.

  • Clarify that ranking operates on RADIX_BITS at a time
  • Fix code example to use unsigned int (not int)
  • Fix typo: BlockRadixSort -> BlockRadixRank
  • Add explanation of extractor behavior

Fixes #3972

@Aminsed Aminsed requested a review from a team as a code owner October 13, 2025 14:56
@Aminsed Aminsed requested a review from NaderAlAwar October 13, 2025 14:56
@github-project-automation github-project-automation bot moved this to Todo in CCCL Oct 13, 2025
Copy link
Contributor

copy-pr-bot bot commented Oct 13, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@cccl-authenticator-app cccl-authenticator-app bot moved this from Todo to In Review in CCCL Oct 13, 2025
//!
//! cub::BFEDigitExtractor<int> extractor(0, radix_bits);
//! // Extract the lowest radix_bits from each key
//! cub::BFEDigitExtractor<unsigned int> extractor(0, radix_bits);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

Suggested change
//! cub::BFEDigitExtractor<unsigned int> extractor(0, radix_bits);
//! cub::BFEDigitExtractor<unsigned> extractor(0, radix_bits);

@Aminsed Aminsed force-pushed the doc/fix_block_radix_rank_docs branch from 456c026 to fd546ed Compare October 13, 2025 20:02
@Aminsed Aminsed force-pushed the doc/fix_block_radix_rank_docs branch from fd546ed to 1d6938e Compare October 13, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

[DOC]: Fix BlockRadixRank documentation

2 participants