-
Notifications
You must be signed in to change notification settings - Fork 283
Replace __popc with cude::std::popcounter #6213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
/ok to test afd9ae6 |
Thanks for working on this :) |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is one more __popc(...)
left in thrust/thrust/system/cuda/detail/set_operations.h
This is done. |
/ok to test 00154d6 |
/ok to test 7f523b4 |
🥳 CI Workflow Results🟩 Finished in 1h 27m: Pass: 100%/171 | Total: 1d 13h | Max: 1h 26m | Hits: 98%/353829See results here. |
@elstehle can I bully you into checking SASS? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed that there are no sass changes.
Fyi, these are the steps I usually follow to check whether there are any sass changes:
- Identify the
Device*
algorithm(s) that may be affected by a change. This isn't always straight-forward. Sometimes, the change may only be affected on certain GPU architectures (this would require looking into the tuning policy of affected algorithms) - Compile the benchmarks for the specific
Device*
algorithm(s) identified in (1) and dump the sass code. E.g.,ninja cub.bench.radix_sort.keys.base && cuobjdump -sass ./bin/cub.bench.radix_sort.keys.base |c++filt > ./radix_sort.keys_after.sass
. - Checkout the
main
branch to compare against baseline sass code being generated:git checkout $(git merge-base HEAD upstream/main)
- Dump the sass code emitted on main branch. E.g.,
ninja cub.bench.radix_sort.keys.base && cuobjdump -sass ./bin/cub.bench.radix_sort.keys.base |c++filt > ./radix_sort.keys_before.sass
. - Check whether there are sass changes:
git diff --text --no-index --word-diff radix_sort.keys_before.sass radix_sort.keys_after.sass
Description
closes #6107
Checklist