Skip to content

[libcu++/cudax] Move all experimental additions to memory resource properties to libcu++ #6233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[libcu++/cudax] Move all experimental additions to memory resource properties to libcu++ #6233

wants to merge 3 commits into from
+164 −192

Conversation

pciolkosz
Copy link
Contributor

This PR removes cudax:: alias for cuda::mr:: properties and move default properties system and properties_list type to libcu++

@pciolkosz pciolkosz requested review from a team as code owners October 14, 2025 20:45
@pciolkosz pciolkosz requested a review from ericniebler October 14, 2025 20:45
@github-project-automation github-project-automation bot moved this to Todo in CCCL Oct 14, 2025
@cccl-authenticator-app cccl-authenticator-app bot moved this from Todo to In Review in CCCL Oct 14, 2025
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

🥳 CI Workflow Results

🟩 Finished in 3h 19m: Pass: 100%/116 | Total: 1d 04h | Max: 1h 31m | Hits: 95%/226302

See results here.

davebayer
davebayer requested changes Oct 15, 2025
View reviewed changes
Copy link
Contributor

@davebayer davebayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add all of the missing _CCCL_API/_CCCL_HOST_API attributes

@github-project-automation github-project-automation bot moved this from In Review to In Progress in CCCL Oct 15, 2025
@pciolkosz
Copy link
Contributor Author

Please, add all of the missing _CCCL_API/_CCCL_HOST_API attributes

By all do you mean only properties_list::has_property? I don't see other functions in the properties.h

davebayer
davebayer approved these changes Oct 15, 2025
View reviewed changes
Copy link
Contributor

@davebayer davebayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By all do you mean only properties_list::has_property? I don't see other functions in the properties.h

Oh sorry, I thought there is much more being transfered to libcu++!

@github-project-automation github-project-automation bot moved this from In Progress to In Review in CCCL Oct 15, 2025
fbusato
fbusato reviewed Oct 15, 2025
View reviewed changes
libcudacxx/include/cuda/__memory_resource/properties.h
//! a template and type arguments with the properties from this list. The properties
//! are appended after the type arguments in the resulting type.
template <class... _Properties>
struct properties_list
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could be used in other contexts as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fbusato fbusato fbusato left review comments

@davebayer davebayer davebayer approved these changes

@ericniebler ericniebler Awaiting requested review from ericniebler ericniebler is a code owner automatically assigned from NVIDIA/cccl-cudax-codeowners

Assignees

No one assigned

Labels

None yet

Projects

CCCL
Status: In Review

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pciolkosz @davebayer @fbusato