[libcu++] Enable complex literals #6252
Merged
+78
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbusato
approved these changes
Oct 15, 2025
| // NOTE: if you get a warning from GCC <7 here that "literal operator suffixes not preceded by ‘_’ are reserved for | ||
| // future standardization" then we are sorry. The warning was implemented before GCC 7, but can only be disabled since | ||
| // GCC 7. See also: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69523 | ||
| _CCCL_API constexpr complex<long double> operator""il(long double __im) |
There was a problem hiding this comment.
my understanding is that we don't support GCC <7, we can get rid of
davebayer
commented
Oct 15, 2025
Comment on lines
+24
to
+26
| // gcc < 8 warns about it's extended literals being shadowed by the implementation, so let's just disable the complex | ||
| // literals | ||
| #if !_CCCL_COMPILER(GCC, <, 8) |
There was a problem hiding this comment.
I had to disable the literals for gcc 7 and older..
|
/ok to test 37aa7fe |
fbusato
approved these changes
Oct 15, 2025
🥳 CI Workflow Results🟩 Finished in 4h 43m: Pass: 100%/84 | Total: 1d 10h | Max: 2h 47m | Hits: 85%/212114See results here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.