Update edge/nvidia-gpu-with-device-edge docs #235
Conversation
edge/nvidia-gpu-with-device-edge.rst
Outdated
| .. code-block:: console | ||
| $ curl -s -L https://gitlab.com/nvidia/kubernetes/device-plugin/-/raw/main/deployments/static/nvidia-device-plugin-privileged-with-service-account.yml | sudo tee /etc/microshift/manifests/nvidia-device-plugin.yml | ||
| $ curl -s -L https://raw.githubusercontent.com/NVIDIA/k8s-device-plugin/refs/heads/main/deployments/static/nvidia-device-plugin-privileged-with-service-account.yml | sudo tee /etc/microshift/manifests/nvidia-device-plugin.yml |
There was a problem hiding this comment.
Microshift works with manifest, we can't update this docs to work with HELM
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
cc @sjug |
Documentation preview |
|
Hey @ArangoGutierrez thanks for the update. I think that the libnvidia-container repo is also wrong? I tried some different RHEL versions but some docs showed it as: That being said, I don't know what is correct. |
ArangoGutierrez
force-pushed
the
update_dp_edge
branch
from
282683c to
dd30097
Compare
Thanks @sjug I have updated the PR, please take a look |
ArangoGutierrez
force-pushed
the
update_dp_edge
branch
from
dd30097 to
2662df9
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR updates the documentation for NVIDIA GPU support with device edge by modernizing the installation and configuration steps. The changes reflect updates to NVIDIA's repository URLs and tooling configuration.
- Updates NVIDIA container toolkit repository URL to use the stable branch instead of a specific RHEL version
- Adds CDI mode configuration for the NVIDIA Container Toolkit
- Updates file paths to use the manifests.d directory structure and changes the device plugin source URL
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
/lgtm Thanks @ArangoGutierrez! |
| .. code-block:: console | ||
| $ curl -s -L https://nvidia.github.io/libnvidia-container/rhel8.7/libnvidia-container.repo | sudo tee /etc/yum.repos.d/libnvidia-container.repo | ||
| $ curl -s -L https://nvidia.github.io/libnvidia-container/stable/rpm/nvidia-container-toolkit.repo | sudo tee /etc/yum.repos.d/libnvidia-container.repo |
There was a problem hiding this comment.
Question: Does it make sense to link to the official docs instead?
There was a problem hiding this comment.
I think is a question for @chenopis
| .. code-block:: console | ||
| $ curl -s -L https://gitlab.com/nvidia/kubernetes/device-plugin/-/raw/main/deployments/static/nvidia-device-plugin-privileged-with-service-account.yml | sudo tee /etc/microshift/manifests/nvidia-device-plugin.yml | ||
| $ curl -s -L https://raw.githubusercontent.com/NVIDIA/k8s-device-plugin/refs/heads/main/deployments/static/nvidia-device-plugin-privileged-with-service-account.yml | sudo tee /etc/microshift/manifests.d/nvidia-device-plugin/nvidia-device-plugin.yml |
There was a problem hiding this comment.
Question: Instead of doing this, does it make sense to generate a YAML file using helm template?
There was a problem hiding this comment.
I think no.
Why: This documentation page is for Microshift users, and they might not have helm installed on their hosts. I understand Helm is our official deployment method, but this is a corner case we are documenting for a platform (user base) that don't use Helm
edge/nvidia-gpu-with-device-edge.rst
Outdated
| $ sudo mkdir -p /etc/microshift/manifests | ||
| $ sudo mkdir -p /etc/microshift/manifests.d/nvidia-device-plugin | ||
| #. The device plugin runs in privileged mode, so you need to isolate it from other workloads by running it in its own namespace, ``nvidia-device-plugin``. To add the plugin to the manifests deployed by MicroShift at start time, download the configuration file and save it at ``/etc/microshift/manifests/nvidia-device-plugin.yml``. |
There was a problem hiding this comment.
This paragraph refers to a different path than the actual code block below.
There was a problem hiding this comment.
Line updated
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
ArangoGutierrez
force-pushed
the
update_dp_edge
branch
from
2662df9 to
b998cbe
Compare
4 participants
No description provided.