-
Notifications
You must be signed in to change notification settings - Fork 29
Container Toolkit 1.18.0 release notes #242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Documentation preview |
b028a5b
to
b3558b1
Compare
@elezar are there any "Enhancements to libnvidia-container" for this release? |
When compared to v1.17.0 there are some fixes that were backported to the maintenance branch: https://github.com/NVIDIA/libnvidia-container/releases/tag/v1.18.0-rc.1 |
I will have a look at this PR and add some more inputs in the coming days. |
@a-mccarthy could we cherry-pick #203 here? |
I have already done it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elezar and @ArangoGutierrez thanks for working on this! I added a few small nits/questions, but otherwise, looks good :)
been resolved for some time now. The inclusion of this hook can still be | ||
triggered when explicitly generating CDI specifications. | ||
- The `legacy` mode of the NVIDIA Container Runtime is deprecated. It is no longer the _default_ mode | ||
when using the `nvidia-container-runtime` is used. It is still supported for use cases where it is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there specific use cases for when its required? This seems a little vague to me for cases where the legacy mode is supported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is intentionally vague, but I can add more context if you think it would help. Places where legacy
mode is required / used:
- The
--gpus
flag is used in Docker without invoking thenvidia
runtime (either as an explicit flag or as the default runtime). - A user has explicitly specified
legacy
as the NVIDIA Container Runtime mode. - Use cases such as
enroot
that invoke thenvidia-container-cli
direclty. - When using CRI-O with an on-disk OCI prestart hook.
- In the case of the GPU Operator where the
legacy
runtime handler is explicitly requested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for clarifying. Its probably ok to leave as is
@ArangoGutierrez pointed out that we need to update the documentation on configuring |
Signed-off-by: Andrew Chen <[email protected]>
Signed-off-by: Andrew Chen <[email protected]>
Signed-off-by: Evan Lezar <[email protected]>
) Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
Signed-off-by: Evan Lezar <[email protected]>
Signed-off-by: Andrew Chen <[email protected]>
Signed-off-by: Andrew Chen <[email protected]>
Co-authored-by: Abigail McCarthy <[email protected]> Signed-off-by: Evan Lezar <[email protected]>
Signed-off-by: Evan Lezar <[email protected]>
Signed-off-by: Evan Lezar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drop-in files addition
LGTM
Preview: https://nvidia.github.io/cloud-native-docs/review/pr-242/container-toolkit/latest/index.html
Signed-off-by: Andrew Chen [email protected]