Skip to content

Conversation

chenopis
Copy link
Collaborator

@chenopis chenopis commented Sep 8, 2025

@chenopis chenopis self-assigned this Sep 8, 2025
@chenopis chenopis requested a review from elezar September 8, 2025 19:27
@chenopis chenopis marked this pull request as draft September 8, 2025 19:28
@github-actions
Copy link

github-actions bot commented Sep 8, 2025

Documentation preview

https://nvidia.github.io/cloud-native-docs/review/pr-242

@chenopis chenopis marked this pull request as ready for review September 9, 2025 22:43
@chenopis
Copy link
Collaborator Author

chenopis commented Sep 9, 2025

@elezar are there any "Enhancements to libnvidia-container" for this release?

@elezar
Copy link
Member

elezar commented Sep 23, 2025

@elezar are there any "Enhancements to libnvidia-container" for this release?

When compared to v1.17.0 there are some fixes that were backported to the maintenance branch: https://github.com/NVIDIA/libnvidia-container/releases/tag/v1.18.0-rc.1

@elezar
Copy link
Member

elezar commented Sep 23, 2025

I will have a look at this PR and add some more inputs in the coming days.

@chenopis chenopis marked this pull request as draft October 7, 2025 17:22
@chenopis chenopis requested a review from a-mccarthy October 7, 2025 20:12
@ArangoGutierrez
Copy link
Collaborator

@a-mccarthy could we cherry-pick #203 here?

@elezar
Copy link
Member

elezar commented Oct 9, 2025

@a-mccarthy could we cherry-pick #203 here?

I have already done it.

@chenopis chenopis marked this pull request as ready for review October 13, 2025 16:38
Copy link
Collaborator

@a-mccarthy a-mccarthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elezar and @ArangoGutierrez thanks for working on this! I added a few small nits/questions, but otherwise, looks good :)

been resolved for some time now. The inclusion of this hook can still be
triggered when explicitly generating CDI specifications.
- The `legacy` mode of the NVIDIA Container Runtime is deprecated. It is no longer the _default_ mode
when using the `nvidia-container-runtime` is used. It is still supported for use cases where it is
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there specific use cases for when its required? This seems a little vague to me for cases where the legacy mode is supported.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is intentionally vague, but I can add more context if you think it would help. Places where legacy mode is required / used:

  • The --gpus flag is used in Docker without invoking the nvidia runtime (either as an explicit flag or as the default runtime).
  • A user has explicitly specified legacy as the NVIDIA Container Runtime mode.
  • Use cases such as enroot that invoke the nvidia-container-cli direclty.
  • When using CRI-O with an on-disk OCI prestart hook.
  • In the case of the GPU Operator where the legacy runtime handler is explicitly requested.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for clarifying. Its probably ok to leave as is

@elezar
Copy link
Member

elezar commented Oct 20, 2025

@ArangoGutierrez pointed out that we need to update the documentation on configuring containerd and / or cri-o with drop-in files. I will add these edits.

Copy link
Collaborator

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop-in files addition
LGTM

@a-mccarthy a-mccarthy merged commit 0cc95ad into main Oct 21, 2025
2 checks passed
@a-mccarthy a-mccarthy deleted the dev-ct-1.18.0 branch October 21, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants