Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing the new NVCF feature enable-gateway-timeout #2576

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Testing the new NVCF feature enable-gateway-timeout #2576

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80345d0
Testing the new NVCF feature enable-gateway-timeout
sacpis Feb 2, 2025
90ec4be
Merge branch 'main' into add_enable_gateway_timeout_header
sacpis Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion runtime/common/BaseRestRemoteClient.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,7 +522,11 @@ class BaseNvcfRuntimeClient : public cudaq::BaseRemoteRestRuntimeClient {
std::map<std::string, std::string> getHeaders() const {
std::map<std::string, std::string> header{
{"Authorization", fmt::format("Bearer {}", m_apiKey)},
{"Content-type", "application/json"}};
{"Content-type", "application/json"},
{"nvcf-feature-enable-gateway-timeout", "true"},
// The max timeout for the polling response is 20 minutes
// https://docs.nvidia.com/cloud-functions/user-guide/latest/cloud-function/api.html#http-polling
{"NVCF-POLL-SECONDS", "1200"}};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What exactly is this doing? I think the prior behavior was that the user would get some sort of "heartbeat" polling message approximately every 5 seconds. Is that going away? Do they have to wait 1200 seconds for that heartbeat now? Does it still run correctly if their job takes ~1 hour?

return header;
};
// Helper to retrieve the list of all available versions of the specified
Expand Down
Loading