Skip to content

CI: Report slow Python tests - #24009

Open
vyasr wants to merge 1 commit into
NVIDIA:mainfrom
vyasr:codex/ci-report-python-test-durations
Open

CI: Report slow Python tests#24009
vyasr wants to merge 1 commit into
NVIDIA:mainfrom
vyasr:codex/ci-report-python-test-durations

Conversation

@vyasr

@vyasr vyasr commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Description

Add the pytest --durations=10 --durations-min=10 option to the cuDF, pylibcudf, and other-Python CI test wrappers. This is diagnostic-only: test selection and behavior are unchanged.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr
vyasr requested a review from a team as a code owner September 6, 2026 23:40
@vyasr vyasr added tests Unit testing for project Python Affects Python cuDF API. Performance Performance related issue ci labels Sep 6, 2026
@vyasr
vyasr requested a review from KyleFromNVIDIA September 6, 2026 23:40
@vyasr vyasr added tests Unit testing for project Python Affects Python cuDF API. Performance Performance related issue ci labels Sep 6, 2026
@coderabbitai

coderabbitai Bot commented Sep 6, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 980ebed0-7993-429a-a6cb-370c277cccc1

📥 Commits

Reviewing files that changed from the base of the PR and between a8ad204 and 26b1069.

📒 Files selected for processing (3)
  • ci/run_pylibcudf_pytests.sh
  • ci/test_python_cudf.sh
  • ci/test_python_other.sh

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Tests

    • Added reporting for the 10 slowest tests taking at least 10 seconds across Python test suites.
    • Added terminal coverage reporting for the dask-cuDF tests.
    • Reformatted the stream-testing command for improved readability.
  • Chores

    • Updated copyright year ranges in the test configuration.

Walkthrough

The CI scripts now report the 10 slowest pytest tests that run for at least 10 seconds. The dask_cudf command also emits terminal coverage output. The cuDF CI copyright notice includes 2026.

Changes

CI pytest reporting

Layer / File(s) Summary
cuDF test reporting
ci/run_pylibcudf_pytests.sh, ci/test_python_cudf.sh
The pylibcudf, cuDF, benchmark, and stream-testing commands now report slow pytest tests. The copyright notice includes 2026 and the NVIDIA affiliates designation.
Other Python test reporting
ci/test_python_other.sh
The dask_cudf, cudf_kafka, custreamz, and cudf_streaming commands now report slow pytest tests. The dask_cudf command also emits terminal coverage.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 26b10

CI Python test wrappers now report slow tests, with terminal coverage output added for dask_cudf. Test selection and execution behavior remain unchanged, and no current merge-blocking risk is identified.

Suggested reviewers: bdice

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 3 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly states that CI will report slow Python tests. It matches the primary change.
Description check ✅ Passed The description accurately explains the added pytest duration reporting and states that test behavior remains unchanged.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@vyasr vyasr added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Performance Performance related issue Python Affects Python cuDF API. tests Unit testing for project

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

1 participant