-
Notifications
You must be signed in to change notification settings - Fork 86
Reduce package sizes #507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce package sizes #507
Conversation
WalkthroughUpdated packaging/build scripts to exclude additional papilo artifacts during wheel repair and wheel creation, remove papilo CMake dependency files during conda install, and reduce the compressed-size threshold in pyproject.toml. Changes
Sequence Diagram(s)sequenceDiagram
participant CI as CI Build
participant CMake as CMake Install
participant Conda as Conda Build
participant Auditwheel as auditwheel repair
participant Wheel as Final Wheel
CI->>CMake: run cmake & install
CMake->>Conda: install tree (includes papilo/_deps)
Conda->>Conda: rm -rf "${PREFIX}/lib/cmake/papilo/_deps"
CI->>Auditwheel: run auditwheel repair (with updated excludes)
Auditwheel->>Wheel: produce repaired wheel (papilo artifacts excluded)
Note over Auditwheel,Conda: pyproject.toml size threshold also lowered before packaging
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (4 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
python/libcuopt/pyproject.toml (1)
85-87: Broaden the_depsexclusion to coverlibinstalls too.CMake can install into either
liborlib64depending on the platform/toolchain. We now drop${PREFIX}/lib/cmake/papilo/_depsin the Conda recipe (Line 137), but the wheel exclusion only matcheslib64. On platforms where the wheel lands underlibcuopt/lib/cmake/..., we’ll still ship the_depstree and lose the size savings. Please include both possibilities (e.g., add a second pattern forlibcuopt/lib/...or use alib*glob) so the cleanup is reliable across build images.Apply this diff:
wheel.exclude = [ - "libcuopt/lib64/cmake/papilo/_deps/**", + "libcuopt/lib64/cmake/papilo/_deps/**", + "libcuopt/lib/cmake/papilo/_deps/**", ]
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
ci/build_wheel_libcuopt.sh(1 hunks)conda/recipes/libcuopt/recipe.yaml(1 hunks)python/libcuopt/pyproject.toml(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
- GitHub Check: wheel-build-cuopt-sh-client / 13.0.1, 3.10, amd64, rockylinux8
- GitHub Check: wheel-build-cuopt-mps-parser / 13.0.1, 3.11, amd64, rockylinux8
- GitHub Check: wheel-build-cuopt-mps-parser / 13.0.1, 3.13, amd64, rockylinux8
- GitHub Check: wheel-build-cuopt-mps-parser / 13.0.1, 3.10, arm64, rockylinux8
- GitHub Check: wheel-build-cuopt-mps-parser / 13.0.1, 3.11, arm64, rockylinux8
- GitHub Check: wheel-build-cuopt-mps-parser / 13.0.1, 3.12, arm64, rockylinux8
- GitHub Check: wheel-build-cuopt-mps-parser / 13.0.1, 3.12, amd64, rockylinux8
- GitHub Check: wheel-build-cuopt-mps-parser / 13.0.1, 3.13, arm64, rockylinux8
- GitHub Check: wheel-build-cuopt-mps-parser / 13.0.1, 3.10, amd64, rockylinux8
- GitHub Check: checks / check-style
|
@coderabbitai approve |
✅ Actions performedComments resolved. |
|
/merge |
1 similar comment
|
/merge |
|
@coderabbitai approve |
✅ Actions performedComments resolved. |
|
/merge |
A follow-up PR for #507, this PR uses EXCLUDE_FROM_ALL on papilo. Authors: - Ramakrishnap (https://github.com/rgsl888prabhu) Approvers: - Trevor McKay (https://github.com/tmckayus) - Vyas Ramasubramani (https://github.com/vyasr) URL: #521
Description
Reduce package sizes which has increased due to underlying thirdpaty modules being pulled in.
Issue
closes #410
closes #181
libcuopt
Before:
cuda -12
cuda -13
After:
cuda-12:
cuda-13:
Checklist
Summary by CodeRabbit