[improvement] : add logic to retry if update fails due to conflict #1838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulait
requested review from
ArangoGutierrez,
cdesiniotis,
elezar,
shivamerla and
tariq1890
as code owners
rahulait
force-pushed
the
add-retry-for-conflicts
branch
2 times, most recently
from
1f03d2c to
d92a721
Compare
Contributor
Author
|
/ok to test d92a721 |
cdesiniotis
approved these changes
Oct 27, 2025
Contributor
cdesiniotis
left a comment
cdesiniotis
left a comment
There was a problem hiding this comment.
Seems reasonable to me. Thanks @rahulait. Let's have others take a look at this as well.
tariq1890
reviewed
Oct 28, 2025
rahulait
force-pushed
the
add-retry-for-conflicts
branch
3 times, most recently
from
060164b to
559c04a
Compare
Contributor
Author
|
/ok to test 559c04a |
Signed-off-by: Rahul Sharma <[email protected]>
rahulait
force-pushed
the
add-retry-for-conflicts
branch
from
559c04a to
a2308d4
Compare
Contributor
Author
|
/ok to test a2308d4 |
tariq1890
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating the resource, we should handle and retry on any conflicts. In this PR, we are wrapping the update call within retry block which will retry update in case of any conflicts.