Build images on PR #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elezar
force-pushed
the
on-pr-images
branch
2 times, most recently
from
5b9aa2b to
df7b270
Compare
|
/ok-to-test |
ArangoGutierrez
approved these changes
Feb 19, 2025
.github/workflows/variables.yaml
Outdated
| GOLANG_VERSION=$(./hack/golang-version.sh || echo "NOT_SUPPORTED") | ||
| echo "Detected $GOLANG_VERSION" | ||
| echo "golang_version=${GOLANG_VERSION}" >> $GITHUB_OUTPUT | ||
|
|
There was a problem hiding this comment.
trailing white line
Use reusable CI workflows to build images per PR. Signed-off-by: Evan Lezar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the github workflow definitions to allow images to be built and published for every PR.
This adapts the changes made in NVIDIA/k8s-device-plugin#1154 for the GPU Device Plugin.