add ngc signing job for auto signing #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elezar
reviewed
Jul 2, 2024
shivakunv
force-pushed
the
ngc_signing_job
branch
from
0923a2e to
cfd59fb
Compare
shivakunv
force-pushed
the
ngc_signing_job
branch
from
cfd59fb to
2b12e7a
Compare
elezar
reviewed
Jul 4, 2024
There was a problem hiding this comment.
Thanks for the changes @shivakunv.
I think we need some minor fixes to cover all the images that we SHOULD be producing.
shivakunv
force-pushed
the
ngc_signing_job
branch
from
c24ea52 to
78561c7
Compare
Please refer for sign jobs: https://gitlab-master.nvidia.com/dl/container-dev/cuda-sample-images/-/merge_requests/1 |
shivakunv
force-pushed
the
ngc_signing_job
branch
from
78561c7 to
dbac40b
Compare
elezar
previously requested changes
Jul 17, 2024
shivakunv
force-pushed
the
ngc_signing_job
branch
from
dbac40b to
70c460e
Compare
elezar
reviewed
Jul 31, 2024
shivakunv
force-pushed
the
ngc_signing_job
branch
from
70c460e to
e26d3f7
Compare
Signed-off-by: shiva kumar <[email protected]>
shivakunv
force-pushed
the
ngc_signing_job
branch
from
e26d3f7 to
48bbea8
Compare
|
@elezar PTAL |
|
@shivakunv can we rebase ? I think we are good to move forward here |
shivakunv
force-pushed
the
ngc_signing_job
branch
from
6996514 to
48bbea8
Compare
shivakunv
dismissed
elezar’s stale review
incorporated all the suggested change.
|
PTAL @elezar @ArangoGutierrez |
ArangoGutierrez
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PTAL @elezar @cdesiniotis