Skip to content

Add support for building ubuntu22.04 on amd64 #1004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 17, 2025
Merged

Conversation

dschervov
Copy link
Contributor

@dschervov dschervov commented Mar 22, 2025

Manual build for nvidia-contaier-toolkit is necessary! It can help open source community with debug and adding new features to this magnificent utility!

Manual build correct working was tested by me on ubuntu22.04 (run docker with gpus all on different models).

Copy link

copy-pr-bot bot commented Mar 22, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@dschervov
Copy link
Contributor Author

@elezar Can you please check my PR?

Copy link
Member

@elezar elezar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dschervov please also add an arm64 target for ubuntu22.04 for consistency.

@dschervov
Copy link
Contributor Author

dschervov commented Apr 6, 2025

@dschervov please also add an arm64 target for ubuntu22.04 for consistency.

Thank you @elezar for your quick response! I am sorry for not responding right away : - (

At that time, I didn't have an ARM64... So I couldn't just send to you something that I am not sure if it would work.

However!!! I have friends who gave me an ARM64! So I implemented your suggestion and tested it. It works perfectly!

@elezar
Copy link
Member

elezar commented Apr 14, 2025

Just a note. The ubuntu18.04 builds should work on newer ubuntu versions too.

@dschervov
Copy link
Contributor Author

Just a note. The ubuntu18.04 builds should work on newer ubuntu versions too.

I appreciate you sharing the knowledge!

@elezar elezar merged commit afc05f6 into NVIDIA:main Apr 17, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants