-
Notifications
You must be signed in to change notification settings - Fork 340
Allow container runtime executable path to be specified #1016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3d0b984
to
1dbba17
Compare
@@ -53,6 +53,11 @@ func Flags(opts *Options) []cli.Flag { | |||
Destination: &opts.Config, | |||
EnvVars: []string{"RUNTIME_CONFIG", "CONTAINERD_CONFIG", "DOCKER_CONFIG"}, | |||
}, | |||
&cli.StringFlag{ | |||
Name: "container-runtime-executable-path", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just executable-path
or runtime-executable-path
? This is consistent with how socket
is named
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think this may be better. Let me take another pass.
1dbba17
to
ae38542
Compare
@tariq1890 do we need to backport this? |
Backporting makes sense since we are most likely releasing gpu-operator v25.3.1 |
Signed-off-by: Evan Lezar <[email protected]>
ae38542
to
3e77955
Compare
This change adds support for specifying the container runtime executable path. This can be used if, for example, there are two containerd or crio executables and a specific one must be used. Signed-off-by: Evan Lezar <[email protected]>
3e77955
to
c57bdf3
Compare
This change adds support for specifying the container runtime executable path. This can be used if, for example, there are two containerd executables and a specific one must be used.
Deploying to a k0s system with:
Allows the config to be extracted correctly and unblocks the deployment.
Fixes #803