Make spark-rapids-ml support ml connect plugin #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bobby Wang <[email protected]>
wbo4958
changed the title
eordentlich
reviewed
Feb 23, 2025
java/src/main/scala/org/apache/spark/ml/rapids/PythonRunner.scala
Outdated
Show resolved
Hide resolved
java/src/main/scala/org/apache/spark/ml/rapids/PythonRunner.scala
Outdated
Show resolved
Hide resolved
eordentlich
reviewed
Feb 24, 2025
|
Curious about our project structure. We have a top-level jvm folder — does it make sense to have this java folder and the scala code together as subdirectories there? |
eordentlich
reviewed
Mar 3, 2025
|
As a follow-up we should remove the Scala code example from the top-level README |
wbo4958
commented
Mar 5, 2025
| * | ||
| * @param uid unique ID of the estimator | ||
| */ | ||
| class RapidsLogisticRegression(override val uid: String) extends LogisticRegression with RapidsEstimator { |
There was a problem hiding this comment.
Hi @eordentlich, How do you think of the naming of RapidsLogisticRegression?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More details can be found at https://github.com/NVIDIA/spark-rapids-ml/pull/835/files#diff-0c997611c3c5fb9fa0641cb88e5aaa485b5fbc7293676fc28afab310dd430812