Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mjcf parser and urdf parser #538

Open
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

etaoxing
Copy link
Contributor

Category

  • New feature
  • Bugfix
  • Breaking change
  • Refactoring
  • Documentation
  • Other (please explain)

Description

(Upstreaming some changes made for Rewarped.)

Update parse_mjcf() and parse_urdf() so that they match better. MJCF parser is heavily modified to match URDF parser. There are minimal changes to the URDF parser, other than now supporting capsules and adding a hide_visuals kwarg.

Changelog

  • Improve parse_mjcf() so that it better matches parse_urdf()
  • Add support for <capsule> to parse_urdf()

Before your PR is "Ready for review"

  • Do you agree to the terms under which contributions are accepted as described in Section 9 the Warp License?
  • Necessary tests have been added
  • Documentation is up-to-date
  • Auto-generated files modified by compiling Warp and building the documentation have been updated (e.g. stubs.py, functions.rst)
  • Code passes ruff check and ruff format --check?

@etaoxing
Copy link
Contributor Author

@eric-heiden

I've tried to make the commit history readable, since this PR makes some large changes to parse_mjcf(), so hopefully the changes are easier to review.

I don't have the bandwidth to add tests, but I can share some MJCF or URDF files that were used if that helps.

@shi-eric shi-eric requested a review from eric-heiden February 21, 2025 05:18
- DeprecationWarning: Support for built-in functions called with non-Warp array types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant