-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mjcf parser and urdf parser #538
Open
etaoxing
wants to merge
23
commits into
NVIDIA:main
Choose a base branch
from
etaoxing:urdf_and_mjcf_parser
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've tried to make the commit history readable, since this PR makes some large changes to I don't have the bandwidth to add tests, but I can share some MJCF or URDF files that were used if that helps. |
- DeprecationWarning: Support for built-in functions called with non-Warp array types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category
Description
(Upstreaming some changes made for Rewarped.)
Update
parse_mjcf()
andparse_urdf()
so that they match better. MJCF parser is heavily modified to match URDF parser. There are minimal changes to the URDF parser, other than now supporting capsules and adding ahide_visuals
kwarg.Changelog
parse_mjcf()
so that it better matchesparse_urdf()
<capsule>
toparse_urdf()
Before your PR is "Ready for review"
stubs.py
,functions.rst
)ruff check
andruff format --check
?