Use configured array length for usize literal generation#370
Open
uurl wants to merge 1 commit into
Open
Conversation
Signed-off-by: Raul Estrada <raulestradaa@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #369
Summary
Use
TyConfig::array_max_lenwhen generating smallusizeliterals instead of relying on the hard-coded value8.Changes
Sombrerodistribution intousize-specific andisize-specific distributions.usizedistribution with the configured upper bound.tcx.config.array_max_lenfromGenLiteral::gen_literal.FIXMEassociated with the hard-coded array-length value.Rationale
Array lengths are configurable, so duplicating the default value in the literal generator can produce inconsistent behavior when
array-max-lenis changed.Using the value from
TyCtxtkeeps literal generation aligned with type generation.Validation
cargo testcargo clippy --all-targetscargo fmt --all --checkcd crates/fuzzer/rustlantis && cargo test -p generate usize_sombrero_uses_configured_small_values_upper_boundcd crates/fuzzer/rustlantis && cargo test -p generatecd crates/fuzzer/rustlantis && cargo clippy -p generate --all-targetscd crates/fuzzer/rustlantis && cargo fmt --all -- --check