Merged
Conversation
Contributor
|
Dallas is indeed backing up to iCloud. Waiting to hear from Chugach |
Collaborator
Author
I'll go ahead and get this in so at least Dallas can test it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR remove the deprecated call
manipulateAsyncinuploadImageand changes theImagePicker.UIImagePickerPreferredAssetRepresentationModefromCompatibletoCurrentThere's an issue we've been seeing from a couple of forecasters where images fail to load from the
ImagePickerwith an unexpected error. I had Claude help investigate and one of the potential reasons it came up with is that the representation modeCompatibletranscodes the image to the most compatible version. According to Claude, this can potentially fail if the image isn't downloaded on the device which would happen, if the image is backed up to iCloud. By setting it to.Current, the picker will just give us the image which we then transcode to a jpg inuploadImageanyway.I tested this on iOS and Android (mainly to make sure the the
uploadImageflow still worked), and with both.heicand.jpgimages.I do not have images backed up to iCloud and doing this is an all or nothing approach so I was not able to test the suspected failing use case